adjust configuration menu for list items, fixes #892 #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hubert Nusser <hubsif@gmx.de>
Signed-off-by: Yannick Schaus <github@schaus.net>
Job #27: Bundle Size — 10.88MB (-0.05%).Changed metrics (3/8)
|
Signed-off-by: Yannick Schaus <github@schaus.net>
ghys
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
We lost the vertical alignment when the item's height is bigger than the button, but it's a small price to pay ;)
I added some last minute fixes to align the item buttons with the "+" button, and fix #919 in the process.
The reason these menus are behind other elements is because the .list CSS class defines z-index: 1 - if you have a z-index anywhere in the tree it will behave like that. So I removed it but in edit mode only, in run mode it's probably best to keep things as they are as much as possible.
Build is green again, so let's merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the custom list item configuration of issue #892.
To achieve this, I moved the level at which a list item menu is created to the parent component (oh-list), like it also is for all other components.
The bug report actually contains another issue, I think, about list items not being display in the widget editor. I'm going to open an extra github issue for that.