This repository has been archived by the owner on May 17, 2021. It is now read-only.
[DSCAlarm] Bug Fix: DSC Alarm Command 060 Not Working #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DSC Alarm command was not working correctly. The binding was erroneously checking for a partition number which is not requirered by this command.
watou
reviewed
Feb 20, 2017
| logger.error("sendCommand(): Partition number must be a single character string from 1 to 8, it was: " + apiData[0]); | ||
| logger.error( | ||
| "sendCommand(): Partition number must be a single character string from 1 to 8, it was: " | ||
| + apiData[0]); |
There was a problem hiding this comment.
Not strictly necessary since the likelihood of errors being configured to be logged is very high, but this could be changed to use parameterized logging instead of string concatenation.
| break; | ||
| } | ||
|
|
||
| if (apiData[1] == null || !apiData[1].matches("[1-4]")) { | ||
| logger.error("sendCommand(): Output number must be a single character string from 1 to 4, it was: " + apiData[1]); | ||
| logger.error("sendCommand(): Output number must be a single character string from 1 to 4, it was: " | ||
| + apiData[1]); |
There was a problem hiding this comment.
Not strictly necessary since the likelihood of errors being configured to be logged is very high, but this could be changed to use parameterized logging instead of string concatenation.
|
Hello John, I took your advise and replaced the string concatenation to the parameterized method. Strange those were the only two like that, the others were the correct way. Thanks. |
watou
pushed a commit
to watou/openhab
that referenced
this pull request
Feb 20, 2017
* [DSCAlarm] Bug Fix: DSC Alarm Command 060 Not Working The DSC Alarm command was not working correctly. The binding was erroneously checking for a partition number which is not requirered by this command. * Removed String Concatonation in logging statements
|
Thanks Russell! Also cherry-picked onto the 1.9.x branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSC Alarm command was not working correctly. The binding was
erroneously checking for a partition number which is not required by
this command. This has been tested as seen here, and found to be working correctly.
Signed-off by: Russell Stephens rsstephens@gmail.com (github:@RSStephens)