This repository has been archived by the owner on May 17, 2021. It is now read-only.
[CalDAV] Various configuration fixes #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9037568
commented
Feb 26, 2017
| defaultTimeZone = DateTimeZone.forID(newTimeZone); | ||
| if (defaultTimeZone == null) { | ||
| log.warn("Invalid timezone value: {}", newTimeZone); | ||
| throw new ConfigurationException("CalDAV IO", "Invalid timezone value: " + newTimeZone); |
There was a problem hiding this comment.
Since we have/use a default timezone already, should we really throw an exception if the timezone in the configuration file isn't valid? Wouldn't it be better to log a warning and proceed to use the default?
There was a problem hiding this comment.
And now I see that I've misconfigured this throw statement. So if we keep the throw, it'll have to be fixed up...
There was a problem hiding this comment.
Updated to use the default TimeZone if the one specified in configuration is invalid.
9037568
commented
Feb 26, 2017
| String[] keys = key.split(":"); | ||
| if (keys.length != 2) { | ||
| log.warn("Unable to parse configuration parameter: {}", key); | ||
| throw new ConfigurationException("CalDAV IO", "Unable to parse configuration parameter: "+key); |
There was a problem hiding this comment.
Here again it seems like we should not throw an exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If config is null, log a warning and return.
Switch to using Objects.toString() for reading config values.
Drop the thrown exceptions for missing username/password, since those values are not required.
Add a warning to the log output if the url is not specified in the configuration.
Use the default TimeZone if the one specified in configuration is invalid.
Misc. fixes in openhab_default.cfg and caldavio.cfg.
Fixes #5116