-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ecotouch] Add divider for analog values and additional temperature values (#5165) #5181
[ecotouch] Add divider for analog values and additional temperature values (#5165) #5181
Conversation
…hab#5165) Also documented new values and some state mappings. Closes openhab#5165 Signed-off-by: Christian Stübner <c.stuebner@digitalvitamin.de> (github: Digitalvitamin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the one typo, I don't see any problems.
Have you had any existing users of the binding test the update for issues with backward compatibility?
### Mappings | ||
|
||
Heatpump event type "state" can be mapped to strings. Different heatpump models seem to have slightly different state values. | ||
Mappings for the Ai1 Geo have been coppied from [here](http://www.haustechnikdialog.de/Forum/t/173357/Waterkotte-via-Ethernet-OpenHAB-und-Android-App?page=6). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"copied"
Thanks for the review. Fixed the typo. |
You could post a thread in the community forum. |
Opened a new topic. |
The binding still works for existing users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
I'd like to give the feedback thread a couple more days soak time, then I think we're good to merge. |
Thanks, @Digitalvitamin ! |
Also documented new values and some state mappings.
Closes #5165
Signed-off-by: Christian Stübner c.stuebner@digitalvitamin.de (github: Digitalvitamin)