Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

[ecotouch] Add divider for analog values and additional temperature values (#5165) #5181

Merged
merged 2 commits into from
May 21, 2017

Conversation

Digitalvitamin
Copy link
Contributor

Also documented new values and some state mappings.

Closes #5165

Signed-off-by: Christian Stübner c.stuebner@digitalvitamin.de (github: Digitalvitamin)

…hab#5165)

Also documented new values and some state mappings.

Closes openhab#5165

Signed-off-by: Christian Stübner <c.stuebner@digitalvitamin.de> (github: Digitalvitamin)
@Digitalvitamin Digitalvitamin changed the title Add divider for analog values and additional temperature values (#5165) [ecotouch] Add divider for analog values and additional temperature values (#5165) May 2, 2017
Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one typo, I don't see any problems.

Have you had any existing users of the binding test the update for issues with backward compatibility?

### Mappings

Heatpump event type "state" can be mapped to strings. Different heatpump models seem to have slightly different state values.
Mappings for the Ai1 Geo have been coppied from [here](http://www.haustechnikdialog.de/Forum/t/173357/Waterkotte-via-Ethernet-OpenHAB-und-Android-App?page=6).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"copied"

@Digitalvitamin
Copy link
Contributor Author

Thanks for the review. Fixed the typo.
I did not get any existing users to test the changes though. How would I find/know any?

@9037568
Copy link
Contributor

9037568 commented May 8, 2017

You could post a thread in the community forum.

@Digitalvitamin
Copy link
Contributor Author

Opened a new topic.

@Digitalvitamin
Copy link
Contributor Author

Digitalvitamin commented May 17, 2017

The binding still works for existing users.
From my point of view its ready to merge.

Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@9037568
Copy link
Contributor

9037568 commented May 18, 2017

I'd like to give the feedback thread a couple more days soak time, then I think we're good to merge.

@9037568 9037568 added this to the 1.10.0 milestone May 18, 2017
@9037568
Copy link
Contributor

9037568 commented May 21, 2017

Thanks, @Digitalvitamin !

@9037568 9037568 merged commit 64720ef into openhab:master May 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants