-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official support for Java 21 #1940
base: main
Are you sure you want to change the base?
Conversation
zigbee2mqtt test is disabled here. Couldn't we enable it back? |
Yep!, I just forgot to after we merged the fix. I'll do that now. |
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@mstormi I can't quite fathom why, but OpenJDK 21 really doesn't like the GitHub Actions env. When I run it locally on Docker it works perfectly but not in Actions. I feel confident enough with all of this for it to be reviewed though. I'm on the fence about defaulting to the Temurin over OpenJDK for 21 because of the issues I'm seeing here and because then it has to use unstable for the source. It also upgrades other packages when installing from unstable because they are dependencies which I don't really like (ie Let me know your thoughts. (There ended up being a bunch of random fixes to automated testing that I found and added while debugging that stupid OpenJDK 21 issue that I never could figure out) |
This also adds checks to make sure that Java 21 is installed before upgrading to openHAB 5.
Fixes #1937