Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Java 21 #1940

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add official support for Java 21 #1940

wants to merge 7 commits into from

Conversation

ecdye
Copy link
Contributor

@ecdye ecdye commented Jan 6, 2025

This also adds checks to make sure that Java 21 is installed before upgrading to openHAB 5.

Fixes #1937

@Larsen-Locke
Copy link
Contributor

zigbee2mqtt test is disabled here. Couldn't we enable it back?

@ecdye
Copy link
Contributor Author

ecdye commented Jan 12, 2025

zigbee2mqtt test is disabled here. Couldn't we enable it back?

Yep!, I just forgot to after we merged the fix. I'll do that now.

ecdye added 4 commits January 12, 2025 23:04
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added 2 commits January 12, 2025 23:15
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@ecdye ecdye marked this pull request as ready for review January 13, 2025 06:32
@ecdye
Copy link
Contributor Author

ecdye commented Jan 13, 2025

@mstormi I can't quite fathom why, but OpenJDK 21 really doesn't like the GitHub Actions env. When I run it locally on Docker it works perfectly but not in Actions. I feel confident enough with all of this for it to be reviewed though.

I'm on the fence about defaulting to the Temurin over OpenJDK for 21 because of the issues I'm seeing here and because then it has to use unstable for the source. It also upgrades other packages when installing from unstable because they are dependencies which I don't really like (ie libc6). Temurin is also now the most widely supported JVM in general that Oracle doesn't build reference implementations anyways.

Let me know your thoughts.

(There ended up being a bunch of random fixes to automated testing that I found and added while debugging that stupid OpenJDK 21 issue that I never could figure out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for Java 21 for OH5?
2 participants