Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Z-Smart Systems ZigBee library to 1.3.10 #616

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

cdjackson
Copy link
Contributor

Signed-off-by: Chris Jackson chris@cd-jackson.com

Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@kaikreuzer kaikreuzer merged commit 06b05cb into openhab:2.5.x Dec 5, 2020
@kaikreuzer kaikreuzer added this to the 3.0.0.M5 milestone Dec 6, 2020
@kaikreuzer
Copy link
Member

@cdjackson Same here: This change was merged to the 2.5.x branch, not against master, while openhab/openhab-distro#1201 clearly was for 3.0, hence I tagged the PR accordingly for 3.0 M5 and had it included in the release notes.
Why is the master branch not maintained on this repo?

@cdjackson
Copy link
Contributor Author

cdjackson commented Dec 14, 2020 via email

@kaikreuzer kaikreuzer removed this from the 3.0.0.M5 milestone Dec 15, 2020
@kaikreuzer
Copy link
Member

Thanks for the update! Sad to hear that you had such a severe IT issue, I wish you the best to get it all fully recovered again!

Please note that since September (and this post), we have the policy that PRs should always go first to master and then being backported to 2.5.x if applicable (see point 2). The idea was to definitely make sure that the latest openHAB version also includes the latest fixes and that those are not forgotten.
This process should ideally also apply to Zigbee and Z-Wave, but I guess that this will come anyhow naturally with 3.0 being released soon (and hardly any further builds happening for 2.5).

@cdjackson
Copy link
Contributor Author

cdjackson commented Dec 15, 2020 via email

@kaikreuzer
Copy link
Member

No need to apologize for anything, really! Just please help to ensure that we don't release 3.0 with broken/outdated Z-bindings, which would really be a shame!

@kaikreuzer
Copy link
Member

@cdjackson I just noticed that this is still missing in master, but I have already triggered the RC2 build, which is supposed to be the final one for testing. Can you confirm that 1.3.10 does not contain any relevant fixes and we are fine to ship 3.0 with the 1.3.8 version?

@cdjackson
Copy link
Contributor Author

cdjackson commented Dec 19, 2020 via email

@kaikreuzer
Copy link
Member

Ok, Chris, thanks for the info and sorry for bothering you. Glad to hear that we can use the current version, so let's leave the upgrade for 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants