Adjust to core changes (addon.xml) #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
6 tasks
kaikreuzer
reviewed
Jan 15, 2023
| <name>ZigBee Binding</name> | ||
| <description>This is the binding for ZigBee providing a vendor neutral ZigBee implementation supporting many different | ||
| ZigBee devices.</description> | ||
| <author>Chris Jackson</author> |
There was a problem hiding this comment.
Following the new rule that we do not use this field for individual authors, shouldn't we rather remove this line, just as we did for all bindings in openhab-addons?
There was a problem hiding this comment.
This rule is not new, we already had it before, I don‘t know why it was not adopted here, so I left it as-is.
There was a problem hiding this comment.
The reason is simple - we simply forgot it, because it was in a different repository.
But you are right, it is not directly related to this PR, so I'll create a separate PR for it.
kaikreuzer
approved these changes
Jan 15, 2023
pgaufillet
pushed a commit
to pgaufillet/org.openhab.binding.zigbee
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONLY merge after the corresponding code PR (openhab/openhab-core#3050) has been merged.
Signed-off-by: Jan N. Klug github@klug.nrw