Skip to content
This repository has been archived by the owner on May 23, 2019. It is now read-only.

Enhancement: ExternalScripts, getItem, and milliseconds option for image #129

Closed
LuckyMallari opened this issue Jan 20, 2017 · 4 comments
Closed

Comments

@LuckyMallari
Copy link
Contributor

LuckyMallari commented Jan 20, 2017

My Changes: https://github.com/LuckyMallari/org.openhab.ui.habpanel

ExternalScripts:
Basically, it adds ../static/habpanel/externalscripts.js to head
Users can then create their own scripts (Angular or not) to their hearts' content.

getItem()
returns item (to access all properties)

Milliseconds:
Image $interval now has 2 options: seconds (default) or milliseconds.
Does not break existing install/configs.

@kubawolanin
Copy link
Contributor

Adding #128 for reference.

@ghys
Copy link
Member

ghys commented Jan 23, 2017

ExternalScripts:
Basically, it adds ../static/habpanel/externalscripts.js to head
Users can then create their own scripts (Angular or not) to their hearts' content.

Sorry, I don't agree with this solution. You can actually lazy load external resources using the ocLazyLoad directive (https://oclazyload.readme.io/docs/oclazyload-directive) but I'm now realizing there is a big security hole with this. I need to address this ASAP.

getItem()
returns item (to access all properties)

This is already covered by #114 which was submitted first.

Milliseconds:
Image $interval now has 2 options: seconds (default) or milliseconds.
Does not break existing install/configs.

Can you please submit a separate PR for this?

Thank you!

@ghys
Copy link
Member

ghys commented Jan 23, 2017

I need to address this ASAP.

Partial mitigation measure in #132 ...it's a shame it didn't make 2.0.0.

@LuckyMallari
Copy link
Contributor Author

Closing issue.
Opened a new PR here:
#133

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants