This repository has been archived by the owner on May 23, 2019. It is now read-only.
Add Content-Security-Policy meta tag #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps mitigate XSS attacks inside expressions and through lazy loading of external scripts by templates/custom widgets. With this CSP policy, only local scripts can be loaded (provided the browser has support for CSP). WARNING: the user is still responsible for securing the openHAB instance properly, especially the REST API endpoints which modify data (POST /service/org.openhab.habpanel/config in particular), including custom code, and *never* publish them unsecured on the Internet. HABPanel lets the user modify templates, and implicitly trusts the code in these templates, therefore XSS attacks and arbitrary code execution is always possible even with the expression sandbox! See: https://docs.angularjs.org/guide/security Signed-off-by: Yannick Schaus <habpanel@schaus.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps mitigate XSS attacks inside expressions and through lazy
loading of external scripts by templates/custom widgets.
With this CSP policy, only local scripts can be loaded
(provided the browser has support for CSP).
WARNING: the user is still responsible for securing the
openHAB instance properly, especially the REST API endpoints
which modify data (POST /service/org.openhab.habpanel/config in
particular), including custom code, and never publish them
unsecured on the Internet.
HABPanel lets the user modify templates, and implicitly trusts
the code in these templates, therefore XSS attacks and arbitrary
code execution is always possible even with the expression sandbox!
See: https://docs.angularjs.org/guide/security
Signed-off-by: Yannick Schaus habpanel@schaus.net