crete check to look for whitespace characters in xml indentation #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpapazow
force-pushed
the
only-tabs-as-xml-indentation
branch
from
f001102
to
9fcd2cb
Compare
kaikreuzer
requested changes
Jan 5, 2018
|
|
||
|
|
||
| /** | ||
| * Cheks whether whitespace characters are use instead of tabs in xml files |
| * Cheks whether whitespace characters are use instead of tabs in xml files | ||
| * indentations and generates warnings in such cases. | ||
| * | ||
| * @author Lyubomir Papazov - initial contribution - |
There was a problem hiding this comment.
what's the trailing dash for?
| <module name="org.openhab.tools.analysis.checkstyle.OnlyTabIdentationInXmlFilesCheck"> | ||
| <property name="severity" value="warning" /> | ||
| <property name="onlyShowFirstWarning" value="true" /> | ||
| </module> |
There was a problem hiding this comment.
This has a different indentation than the opening element.
lpapazow
force-pushed
the
only-tabs-as-xml-indentation
branch
from
9fcd2cb
to
d8f8180
Compare
Signed-off-by: Lyubomir V. Papazov <lpapazow@gmail.com>
lpapazow
force-pushed
the
only-tabs-as-xml-indentation
branch
from
d8f8180
to
e1ca021
Compare
martinvw
reviewed
Jan 28, 2018
| */ | ||
| public class OnlyTabIdentationInXmlFilesCheck extends AbstractStaticCheck { | ||
|
|
||
| private static final String PATTERN_TO_BE_FOLLOWED = "^\\t*[<].*"; |
There was a problem hiding this comment.
This regex is just wrong. Should you maybe rather check on lines starting with spaces?
According to this regex you can not have lines with multi-line CDATA blocks, you can not split your header like the common example.
<thing:thing-descriptions bindingId="onewiregpio" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:thing="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0"
xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0
http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">
There was a problem hiding this comment.
And quickly reading its not even allowed to have empty lines?
There was a problem hiding this comment.
I didn't think of those cases. I'll change it asap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a check that verifies that XML files use tabs instead of spaces as suggested here