Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to core changes (addon.xml) #444

Merged
merged 3 commits into from
Feb 12, 2023
Merged

Adjust to core changes (addon.xml) #444

merged 3 commits into from
Feb 12, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 15, 2023

@J-N-K J-N-K requested a review from a team as a code owner January 15, 2023 22:38
@openhab-bot
Copy link

Can't set status; build failed.

@J-N-K
Adjust to core changes (addon.xml)
ccca5c9 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Jan 15, 2023

I think now that we have addon.xml for every add-on it would be good to have a check if that is present. Unfortunately I did not find out how to declare exceptions based on the module name, which is necessary e.g. for org.openhab.mqtt.homie (because the XML is on the "base project" org.openhab.binding.mqtt

@J-N-K J-N-K closed this Jan 16, 2023
@J-N-K J-N-K reopened this Jan 16, 2023
@J-N-K
fix
d9623ac 
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
wborn reviewed Feb 12, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!
There could be a small improvement:

...le/src/test/java/org/openhab/tools/analysis/checkstyle/test/OhInfXmlValidationCheckTest.java Outdated
@@ -162,7 +162,7 @@ public void testInvalidBinding() throws Exception {

int lineNumber = 7;
String[] expectedMessages = generateExpectedMessages(lineNumber,
"The content of element binding:binding is not complete. One of {name} is expected.");
"The content of element addon:addon is not complete. One of {type} is expected.");
verifyWithPath("invalidBinding", RELATIVE_PATH_TO_BINDING, expectedMessages);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also renaming the test to testInvalidAddon and:

Suggested change
verifyWithPath("invalidBinding", RELATIVE_PATH_TO_BINDING, expectedMessages);
verifyWithPath("invalidAddon", RELATIVE_PATH_TO_ADDON, expectedMessages);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

wborn
wborn approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wborn wborn merged commit 41fd242 into openhab:main Feb 12, 2023
@wborn wborn added this to the 0.14.0 milestone Feb 12, 2023
@J-N-K J-N-K deleted the addonxml branch February 12, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @openhab-bot @wborn