Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted scripts and config to OH3 branching. #222

Closed

Conversation

Confectrician
Copy link
Contributor

CC: @kaikreuzer @ghys

Since master branches switched to OH3 and habmin/classicui were removed in openhab-webui repo,
the website build is broken. (Also the previes, for the same reason.)

I have removed the legacy uis from docs generation.
Also i removed the corresponding sidebar entries.

Will do the same for the related scripts and configs in the docs repo.
This includes vuepress related scripts and also our gathering bash script, for external contents.
(PR will follow over there.)

Signed-off-by: Jerome Luckenbach github@luckenba.ch

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@kaikreuzer
Copy link
Member

In the light of #221, it is probably a good thing that the website generation broke, so that not all add-on documentation is deleted?

@Confectrician
Copy link
Contributor Author

From what i have loked up here:
https://ci.openhab.org/view/Documentation/job/gather-external-docs/427/consoleFull
and here:
openhab/openhab-docs@872bbe0

The oh2 addons are gathered so far.
Some warnings below in the copy-rename part, just the deletion notices for habmin and classicui at the bottom of the log.
We should evaluate that a bit more, but I would guess that the build will work for addons according to the openhab-addons master branch.
The commit history of the openhab-docs final branch looks good too so far.

Providing 2.5.x information for patch releases is another topic we will have to deal with this year.
(But thats kind of off topic now.)

@kaikreuzer
Copy link
Member

the build will work for addons according to the openhab-addons master branch

You are aware that this master branch does not contain ANY add-on? That's why I was concerned that they are all removed from the website, if the build succeeds.

Providing 2.5.x information for patch releases is another topic we will have to deal with this year.

Hm, no, I was actually thinking that this is what we need right now - simply adapt the docs build to use the 2.5.x branch (instead of master) from the openhab-addons repo and all would be fine. Am I missing something?

@Confectrician
Copy link
Contributor Author

You are aware that this master branch does not contain ANY add-on?

Forget everything i wrote above...
I checked the repo and didn't notice that the default visible branch is 2.5.x instead of master already.
(That happens, when one is used to have master as the overall default^^)
Sorry for the confusion.

As said in #221 -> We can postpone this PR then for now and should get docs running again based on 2.5.x branches where needed.

@Confectrician Confectrician deleted the fix-oh3-branch-build branch December 24, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants