Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pine sidebar entry #243

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

Confectrician
Copy link
Contributor

Preparation for openhab/openhab-docs#1240

Signed-off-by: Jerome Luckenbach github@luckenba.ch

Preparation for openhab/openhab-docs#1240

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@Confectrician Confectrician merged commit a374584 into v2 Jun 17, 2020
@Confectrician Confectrician deleted the Confectrician-remove-pine-link branch June 17, 2020 17:17
@ghys
Copy link
Member

ghys commented Jun 17, 2020

@Confectrician just do you know, you won't have to do that stuff anymore with v3 (master) since it picks up the sidebar on the docs repo ;)

const DocsSidebarNavigation = require('./openhab-docs/.vuepress/docs-sidebar.js')

website/.vuepress/config.js

Lines 189 to 190 in 5fdf18e

sidebar: {
'/docs/': DocsSidebarNavigation,

Could probably do it for v2 as well but 🤷‍♂️

@Confectrician
Copy link
Contributor Author

Good news. :)

But v3 should be enough.
I can take care of the v2 part until it is obsolete. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants