Added download redirects #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us a chance to not hard-code jfrog urls anywhere in our distro. Related to openhab/openhab-distro#1256 Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
That works awesome on the preview! 😄 |
|
Nice! Wouldn't that mean a lot of 302 redirects, one for every download? This shouldn't have a big impact on speed & bandwidth but who knows... |
|
We have around 500-1000 (manual, not apt) downloads a day - that's less than one request per minute, so that shouldn't be an issue really. |
ghys
approved these changes
Mar 26, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a chance to not hard-code jfrog urls anywhere in our distro.
Related to openhab/openhab-distro#1256
Signed-off-by: Kai Kreuzer kai@openhab.org