-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starred obs #1224
Open
fredkingham
wants to merge
22
commits into
v0.98
Choose a base branch
from
starred-obs
base: v0.98
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Starred obs #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nish immediately after the mouse over
… if its starred, totherwise it returns None. If a starred observation is not already returned then its added to the ticker
…en put the value on the row below
…mmary api as we have disabled the ability to unstar from this panel
… we have disabled the ability to unstar from this panel
…e episode category page. The consequence of this is that we had to uncache the results view which is costly in performance. It also meant we had to uncache the episode detail page. This behaviour would break on any other page that wanted to reuse the results panel. This change means that we cache everything apart from the panel that we reload when the view changes
fredkingham
force-pushed
the
starred-obs
branch
from
November 1, 2021 16:25
7f97047
to
599bc82
Compare
…again does not necessarily change the episode.category_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.