Adds the non zero prefixed MRN database constraint #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a database constraint to make it so that it is impossible to change an MRN so that it has a zero prefix.
|
Does the constraint work if we deploy it to a database that hasn't yet been cleansed of 0prefixes? |
davidmiller
reviewed
Apr 12, 2023
| @@ -75,6 +75,12 @@ def age(self): | |||
|
|
|||
| class Meta: | |||
| verbose_name_plural = "Demographics" | |||
| constraints = [ | |||
| models.CheckConstraint( | |||
| check = ~models.Q(hospital_number__startswith=0), | |||
There was a problem hiding this comment.
I think I landed at either a different spelling or a comment explaining how bitwise not works here...
Negation of a Q expression is done with a tilda ('~') this looks wrong
at first glance so a comment has added with a link to the django
documentation to explain the syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a database constraint to make it so that it is impossible to change an MRN so that it has a zero prefix.
Tested with csv imports and bulk updates.