Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin/meta-packages: use singularity-ce on rhel clones #1645

Merged
merged 1 commit into from
Jan 11, 2023
Merged

admin/meta-packages: use singularity-ce on rhel clones #1645

merged 1 commit into from
Jan 11, 2023

Conversation

adrianreber
Copy link
Member

Previously EPEL had the apptainer package which had a 'Provides: singularity'. This was removed: https://pagure.io/epel/issue/214

The changes the OpenHPC meta-package to use the package singularity-ce on RHEL clones.

@adrianreber
Copy link
Member Author

This tries to solve #1644

@mghpcsim @koomie Do we want a fix like this for the current problems as reported via the mailing list, slack and GitHub?

@adrianreber adrianreber force-pushed the 2023-01-06-singularity branch from 48ce70e to 5ae4609 Compare January 6, 2023 10:44
martin-g
martin-g approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianreber adrianreber force-pushed the 2023-01-06-singularity branch from 5ae4609 to 3b8d7c3 Compare January 11, 2023 07:30
@adrianreber
admin/meta-packages: use singularity-ce on rhel clones
891e2a7 
Previously EPEL had the apptainer package which had a 'Provides:
singularity'. This was removed: https://pagure.io/epel/issue/214

The changes the OpenHPC meta-package to use the package singularity-ce
on RHEL clones.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber force-pushed the 2023-01-06-singularity branch from 3b8d7c3 to 891e2a7 Compare January 11, 2023 07:38
@martin-g martin-g mentioned this pull request Jan 11, 2023
Closed
@adrianreber
Copy link
Member Author

I changed the Requires: to a Recommends: of either singularity-ce or apptainer or singularity.

This way, if either singularity-ce or apptainer or singularity is available it will be installed. If it is not available dnf will just continue. If the user has already one of the package pre-installed it should also just work.

Using Recommends: also offers the possibility that the user can uninstall the package later if needed.

@koomie koomie merged commit a47c0ab into openhpc:2.x Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianreber @martin-g @koomie