Update lmod to 8.7.32 #1906
Merged
Update lmod to 8.7.32 #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Reber <areber@redhat.com>
Should fix errors seen with the Intel compiler modulefiles. Signed-off-by: Adrian Reber <areber@redhat.com>
martin-g
reviewed
Nov 3, 2023
| @@ -97,7 +97,7 @@ make DESTDIR=$RPM_BUILD_ROOT install | |||
| ######################################################################## | |||
|
|
|||
| # NOOP if running under known resource manager | |||
| if [ ! -z "\$SLURM_NODELIST" ] | [ ! -z "\$PBS_NODEFILE" ]; then | |||
| if [ -n "\$SLURM_NODELIST" ] || [ -n "\$PBS_NODEFILE" ]; then | |||
There was a problem hiding this comment.
Shouldn't || be && ? I.e. if neither is defined then return early.
There was a problem hiding this comment.
Hmm, good question. Let me take a look.
There was a problem hiding this comment.
Just tested a couple of combinations and it works as expected. The goal is, if one is set it should return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1905