Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Regenerate modulefiles on update (fixes #1601) #1984

Draft
wants to merge 3 commits into
base: 3.x
Choose a base branch
from

Conversation

opoplawski
Copy link
Contributor

This is as yet completely untested. But the idea is:

  • Split out the module generation into a separate script into a new bin directory. I think admins may want to run this at times as well
  • Update the script to only generate .rpmnew files if the files are different than the currently installed ones
  • Run that script whenever the /opt/intel/oneapi directory is updated by another rpm
  • Only run the %postun script when the package is completely removed, not on updates

Does the CI generate rpms that can be tested?

Copy link

github-actions bot commented May 25, 2024

Test Results

0 files   - 14  0 suites   - 14   0s ⏱️ -6s
0 tests  - 41  0 ✅  - 41  0 💤 ±0  0 ❌ ±0 
0 runs   - 54  0 ✅  - 54  0 💤 ±0  0 ❌ ±0 

Results for commit e221fee. ± Comparison against base commit 792e7cd.

♻️ This comment has been updated with latest results.

@opoplawski opoplawski marked this pull request as draft May 25, 2024 18:08
Signed-off-by: Orion Poplawski <orion@nwra.com>
@adrianreber
Copy link
Member

Does the CI generate rpms that can be tested?

Yes, for each OS there should be an RPM attached to the GitHub Actions. The RPMs are only kept for 24 hours however, previously we reached space limits keeping them for a longer time.

Thanks for your PR. I will need at least one week before being able to look closer at this PR.

@adrianreber
Copy link
Member

I would like to run new shell scripts through shellcheck. We have a https://github.com/openhpc/ohpc/blob/3.x/tests/ci/Makefile which does that for us. Could you add the new shellscript to the shellcheck, whitespace and shfmt sections there. If you prefer to not do these changes I can also do them later.

There is a similar script in the intel MPI compatibility package. I guess we should do the same changes there, right?

Signed-off-by: Orion Poplawski <orion@nwra.com>
Signed-off-by: Orion Poplawski <orion@nwra.com>
@opoplawski
Copy link
Contributor Author

Am I right that shmft want TAB characters for indentation?

@adrianreber
Copy link
Member

adrianreber commented Jul 4, 2024

Am I right that shmft want TAB characters for indentation?

We just use the defaults that shfmt defines. The main goal is to be consistent. I never looked at the details.

Just running make -C tests/ci/ shfmt-lint should fix it.

Copy link

github-actions bot commented Aug 9, 2024

A friendly reminder that this PR had no activity for 30 days.

@aflyhorse
Copy link
Contributor

Any update on the PR? Still cannot upgrade oneAPI smoothly.

@github-actions github-actions bot removed the stale-pr label Nov 6, 2024
@adrianreber adrianreber added this to the 3.3 milestone Nov 7, 2024
Copy link

github-actions bot commented Dec 8, 2024

A friendly reminder that this PR had no activity for 30 days.

@aflyhorse
Copy link
Contributor

(This is just a message to prevent expiration. Please ignore it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants