Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CV32E40Pv2_not_verified_features.xlsx #677

Merged

Conversation

XavierAubert
Copy link
Contributor

@XavierAubert XavierAubert commented Jun 10, 2024

Added a file that contains more informations on verification limitations and features not verified.

Feel free to tell me if there is anything missing or if I am not commiting in the right place

Added a file that contains more informations on verification limitations
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this document @XavierAubert! I would ask for one change. In cell F7 it says:

RTL freeze criteria for Dolphin Desgin but not for OHG

That is technically correct (except for the typo in Design 😉), but could expand it to say:

RTL freeze criteria for Dolphin Design but not for OpenHW Group.  FSM Transition and State are encompassed by Branch plus Condition code coverage.

@pascalgouedo
Copy link
Contributor

FSM Transition and State are encompassed by Branch plus Condition code coverage.

Not sure this is enough. For instance in the controller there are 2 "dead states" when COREV_CLUSTER == 0, i.e. ELW_EXE and IRQ_FLUSH_ELW. But they are still there in the FSM.
And they are reported by lint check:

FSM_UNREACHABLE_STATE: FSM 'top_i.core_i.id_stage_i.controller_i.ctrl_fsm_cs', State IRQ_FLUSH_ELW
FSM_UNREACHABLE_STATE: FSM 'top_i.core_i.id_stage_i.controller_i.ctrl_fsm_cs', State ELW_EXE
FSM_UNREACHABLE_TRANS: FSM 'top_i.core_i.id_stage_i.controller_i.ctrl_fsm_cs', Transition DECODE -> ELW_EXE
FSM_UNREACHABLE_TRANS: FSM 'top_i.core_i.id_stage_i.controller_i.ctrl_fsm_cs', Transition DECODE_HWLOOP -> ELW_EXE

Hopefully these 2 checks severity is Caution and not Error...

@MikeOpenHWGroup
Copy link
Member

For instance in the controller there are 2 "dead states"

Interesting point. My statement assumes that there are no dead states.

@pascalgouedo
Copy link
Contributor

Could FSM DEAD STATES and FSM UNREACHABLE TRANSITION be RTL Freeze blocking points?
Not mentioned in RTL checklist today but could improve the RTL quality...

But too late for CV32E40Pv2!

Took into account Mike comments
@XavierAubert
Copy link
Contributor Author

XavierAubert commented Jun 12, 2024

I corrected the typo and added "plus Statements" to your words, so at least it encompasses as well unreachable states with waived code.
Regarding dead ends, for me, it is why 100% FSM coverage is required at Dolphin ;)

@MikeOpenHWGroup
Copy link
Member

Regarding dead ends, for me, it is why 100% FSM coverage is required at Dolphin ;)

You are right @XavierAubert, it is often better to include such coverage so we do not need to have these debates! 😝

As @pascalgouedo, says, it is too late for CV32E40Pv2 and I am content to sign-off on what we have today.

@MikeOpenHWGroup MikeOpenHWGroup merged commit 14690ab into openhwgroup:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants