Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Improve HTML page when authorization completes in the browser #633

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roop
Copy link

@roop roop commented Apr 29, 2021

When using AppAuth in macOS, AppAuth creates a local webserver in the app so that the authorization flow can use the default browser. Once the authorization flow completes, the page shown on the tab used for authorization is currently a very bare HTML page with no styling at all. This PR adds some basic styling that makes the page look better. The same HTML template is used in case authorization succeeded or failed.

@roop roop force-pushed the macos_better_looking_html_page branch from 9dd840e to 69304aa Compare April 30, 2021 07:07
@roop
Copy link
Author

roop commented Apr 30, 2021

The "swift test" failure in travis-ci seems to be unrelated to this change -- it still fails without these changes.

@stefanfuerst
Copy link

I like the idea of a nicer HTML page.
However, I would prefer to provide the strings by accessors instead of statics.
This way you cloud subclass OIDRedirectHTTPHandler and show your own localised strings to the enduser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants