-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OIDExternalUserAgentIOSCustomBrowser on iOS 10+ #871
Conversation
@yalkhder Do you know why the I tried the check's steps on my machine, that passed: `swift test` output...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loic-sharma thanks for this fix for OIDExternalUserAgentIOSCustomBrowser, the last check spm-build-test in github-actions is failing. Could you please look into it?
Please merge it as |
@ankushkushwaha Please see my message above. The test passes locally on my machine. I can't see the CI's output, so I can't tell what's going wrong there. Would you be able to help get additional information from the CI failure? |
The failing test says You could try pushing an empty commit to get CI to run again. |
Or you could try updating the MacOS version at https://github.com/openid/AppAuth-iOS/blob/c89ed571ae140f8eb1142735e6e23d7bb8c34cb2/.github/workflows/tests.yml#L53C4-L53C22 @loic-sharma As MacOS 11 runners are no longer available on GitHub, then the test will never pass 😢 |
@robwalkerco @ankushkushwaha Thanks for sharing the CI output! I've updated the Could you run the CI checks again please? :) |
Hi everyone! I have PR #879 approved and soon to be merged in so this should resolve the failing check. There seemed to be a failing codecov issue upon updating the macos runner. @loic-sharma I'll rerun the checks once that PR is merged in. |
@loic-sharma, do you mind updating your branch with main again to take in the changes? |
50ed838
to
6ec0ef7
Compare
@brnnmrls thanks for the ping - I've rebased my branch! |
@brnnmrls will there be a new release soon with this fix? |
@brnnmrls Any news about releasing a new package version with that work? Thanks |
Hi everyone, we expect this to be released by the end of this week. I'll keep y'all posted if things change. |
Update: I ran into some issues with testing so I'll be releasing this early next week. Apologies for the delay! |
Update: It's been released under 1.7.6! |
Seems like iOS problem: https://forums.developer.apple.com/forums/thread/764468 |
UIApplication openURL:
is deprecated and has no effect.On iOS 10.0+,
UIApplication openURL:options:completionHandler:
should be used instead.I am contributing on behalf of Google, which has a CLA with the OpenID Foundation.
Relevant issue: #703