-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: section Media Type Registration for wallet-attestation+jwt #86
base: main
Are you sure you want to change the base?
Conversation
Doesn't this belong into attestation based client authentication draft? |
I was wondering the same during its writing, I followed the related issue for its resolution. If confirmed I can move this PR to attestation-based client auth draft. |
draft-oid4vc-haip-sd-jwt-vc.md
Outdated
@@ -374,6 +374,39 @@ Note: When using this profile with other cryptosuites, it is recommended to be e | |||
|
|||
`iat` and `exp` JWT claims express both the validity period of both the signature and the claims about the subject, unless there is a separate claim used to express the validity of the claims. | |||
|
|||
# Security Considerations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change does not belong to this PR, please revert
draft-oid4vc-haip-sd-jwt-vc.md
Outdated
* Required parameters: n/a | ||
* Optional parameters: n/a | ||
* Encoding considerations: binary; A JWT-based Wallet Instance Attestation object is a JWT; JWT values are encoded as a series of base64url-encoded values (some of which may be the empty string) separated by period ('.') characters. | ||
* Security considerations: See (#security-considerations) of [[ this specification ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this attestation is defined in Section {#wallet-attestation-schema}, security considerations related to the attestation should be specified there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have changed the link/ref to #wallet-attestation-schema
I think HAIP is the right place as the wallet attestation is defined here. The attestation based client authentication draft just defines the underlying OAuth mechanics but is not specific to wallet attestations. I think this whole module should be moved into VCI. |
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
we may adapt this to terminology WTE and WIA |
Shouldn't this PR also introduce the |
this PR Closes #67