CM-137: add TaskGroup to django ORM #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborowiecki
requested changes
Jun 25, 2023
There was a problem hiding this comment.
I also left some minor comments @jdolkowski. Please refer to them. Let me know if you apply all changes requested by me and Damian. After that I will re-check this whole PR.
sniedzielski
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openimis.atlassian.net/browse/CM-137
This PR adds TaskGroup to django ORM. It was not possible to use django groups mentioned in the ticket since ID field of HistoryModel and DjangoGroup clashed with each other.
This PR needs to be merged first: openimis/openimis-be-core_py#195