Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/24.04 #239

Merged
merged 116 commits into from
May 2, 2024
Merged

Release/24.04 #239

merged 116 commits into from
May 2, 2024

Conversation

delcroip
Copy link
Member

@delcroip delcroip commented May 2, 2024

No description provided.

dragos-dobre and others added 30 commits September 15, 2023 18:31
* Test Job split

* Added runson

* Changed dependency

* PSQL Tests as separate job

* Fixed syntax

* Split test execution and report

* Split test execution and report

* FIX CI

* Fix CI

* Extended .flake8

* Changed sed

* Another sed fix

* sed for flake8

* scm provider added
* add-sonar-ci: add ci file

* add-sonar-ci: update ci file

* add-sonar-ci: add sonar ci to assemlby

* add-sonar-ci: update sonar properties

---------

Co-authored-by: Jan <j.dolkowski@soldevelo.com>
* add sripts to clone..

* add branch checkout

* fixing pip cmd

* docker database using image

* DO NOT LOAD TEST db

* stop using special test db schema
The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-TWISTED-6036202
* add sripts to clone..

* add branch checkout

* fixing pip cmd

* docker database using image

* DO NOT LOAD TEST db

* stop using special test db schema
* Update ci_module.yml

* Update ci_assembly.yml

* Update ci_assembly.yml

* Update ci_module.yml
Added support for environment variable OPENIMIS_CONF
Copy link

gitguardian bot commented May 2, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9691499 Triggered Generic Database Assignment a4b6910 .env.example View secret
9691499 Triggered Generic Database Assignment 3533ef2 .env.example View secret
3700481 Triggered Django Secret Key 782eef8 openIMIS/openIMIS/settings.py View secret
3700481 Triggered Django Secret Key 487dd8e openIMIS/openIMIS/settings.py View secret
3700481 Triggered Django Secret Key 8ea0c8a openIMIS/openIMIS/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

import re

def parse_pip(pip_str):
if "https://github.com" in pip_str:

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

The string
https://github.com
may be at an arbitrary position in the sanitized URL.
print("Error name not found")

def parse_npm(npm_str):
if "https://github.com" in npm_str:

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

The string
https://github.com
may be at an arbitrary position in the sanitized URL.
assembly_be='openimis/openimis-be_py'
#refresh openimis.json from git

be_config = []

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable be_config is not used.
match = re.search(r'github.com/(.+).git',npm_str )
return match.group(1)
else:
match = re.search(r'@openimis/(.+)@',npm_str )

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable match is not used.
DEFAULT_DB_LOGGING_HANDLER = os.getenv("DJANGO_DB_LOG_HANDLER", "db-queries")
LOGGING_LEVEL = os.getenv("DJANGO_LOG_LEVEL", "DEBUG" if DEBUG else "WARNING")
if DEBUG:
EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'EMAIL_BACKEND' is unnecessary as it is
redefined
before this value is used.
@@ -1,3 +1,5 @@
from channels.auth import AuthMiddlewareStack
import dashboard_etl.routing

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'dashboard_etl' is not used.
@@ -0,0 +1,33 @@
import os
from git import Repo
from config import GITHUB_TOKEN, USER_NAME, BRANCH

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'BRANCH' is not used.
@@ -0,0 +1,51 @@
from config import GITHUB_TOKEN, USER_NAME, BRANCH

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'BRANCH' is not used.
@@ -0,0 +1,51 @@
from config import GITHUB_TOKEN, USER_NAME, BRANCH
from utils import parse_pip, walk_config_be

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'parse_pip' is not used.
from django.core.management.base import BaseCommand
from pathlib import Path

from openIMIS.openimisapps import openimis_apps

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'openimis_apps' is not used.
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@delcroip delcroip merged commit 3ae6658 into main May 2, 2024
4 of 8 checks passed
@dragos-dobre dragos-dobre deleted the release/24.04 branch May 13, 2024 15:49
@delcroip delcroip restored the release/24.04 branch July 4, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants