OP-2325: deleted TLS/SSL connection from allowed hosts #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
I think It should by ok as a scope of default settings. On server this 'CSRF' will look differently due to having 'https' turn on. @lruzicki
@delcroip Please take a look into that change. As I mentioned above - it shouldn't affect local settings, but I'm a little afraid about 'server' environments like 'demo/release/develop/demo coreMIS' envs.
delcroip
approved these changes
Dec 23, 2024
|
@sniedzielski this change affect only dev changes; ideally we should also use protos and ports env VAR but we discussed with @lruzicki to keep it simple for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
https://openimis.atlassian.net/browse/OP-2325
Changes:
How was it tested?