Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: del the open-util pkg #377

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix: del the open-util pkg #377

merged 1 commit into from
Jan 17, 2024

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Jan 16, 2024 •
edited
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #378

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@luhaoling luhaoling requested review from cubxxw and a team as code owners January 16, 2024 07:50
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2024
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Jan 16, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@cubxxw cubxxw enabled auto-merge January 16, 2024 13:47
@cubxxw cubxxw added this pull request to the merge queue Jan 17, 2024
Merged via the queue into openimsdk:main with commit 097ab43 Jan 17, 2024
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Jan 17, 2024
@luhaoling luhaoling deleted the util branch January 22, 2024 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: relace the open-util by errs
3 participants
@luhaoling @FGadvancer @cubxxw