Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactoring callbackexample #395

Merged
merged 17 commits into from
Jan 26, 2024
Merged

fix: Refactoring callbackexample #395

merged 17 commits into from
Jan 26, 2024

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Jan 24, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #396

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@luhaoling luhaoling requested review from cubxxw and a team as code owners January 24, 2024 10:24
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2024
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2024
@luhaoling luhaoling changed the title fix: fix the logs output path fix: Refactoring callbackexample Jan 25, 2024
cubxxw
cubxxw previously approved these changes Jan 25, 2024
@cubxxw cubxxw enabled auto-merge January 25, 2024 10:51
@FGadvancer FGadvancer added this pull request to the merge queue Jan 26, 2024
Merged via the queue into openimsdk:main with commit 8ea1377 Jan 26, 2024
21 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: refactor callbackExample and let it show clearly
3 participants