Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: jssdk server optimize #422

Closed
2 tasks done
cubxxw opened this issue May 25, 2023 · 5 comments
Closed
2 tasks done

Feature: jssdk server optimize #422

cubxxw opened this issue May 25, 2023 · 5 comments
Labels
feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone
v3.4

Comments

@cubxxw
Copy link
Contributor

cubxxw commented May 25, 2023

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the OpenIMSDK Slack and got positive feedback

Is this feature request related to a problem?

❎ No

Problem Description

jssdk server optimization

Solution Description

The current jssdk server module is a mess to write, but the refactored version is more elegant and testable

Benefits

It improves the readability and maintainability of the code

Potential Drawbacks

no

Additional Information
@cubxxw cubxxw added the feature Categorizes issue or PR as related to a new feature. label May 25, 2023
@cubxxw cubxxw added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 25, 2023
@cubxxw cubxxw added this to the Large refactoring efforts milestone May 25, 2023
@cubxxw cubxxw moved this to To Do in openim-powerful May 25, 2023
@cubxxw cubxxw removed this from openim-powerful Jun 8, 2023
@cubxxw cubxxw moved this to To Do in openim-powerful Jun 8, 2023
@kubbot
Copy link
Contributor

kubbot commented Jul 25, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@cubxxw cubxxw added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 2, 2023
@kubbot
Copy link
Contributor

kubbot commented Aug 2, 2023

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨
Join slack 🤖 to connect and communicate with our developers.
If you wish to accept this assignment, please leave a comment in the comments section: /accept.🎯

@cubxxw cubxxw modified the milestones: v3.1, v3.4 Sep 28, 2023
@kubbot
Copy link
Contributor

kubbot commented Mar 3, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

luhaoling added a commit to luhaoling/open-im-server that referenced this issue Mar 5, 2024
@luhaoling
fix: add graceful exit logic (openimsdk#422)
b5e99dc 
* fix: fix the component check logic

* fix: add graceful_exit in admin-api

* fix: fix the graceful exit logic

* fix: add rpc graceful logic

* fix: del the http port

* fix: add graceful logic in chat-api

* fix: update the func location

* fix: fix the error

* fix: fix the error

* fix: test the func loc

* fix: fix the tools version
@kubbot
Copy link
Contributor

kubbot commented Mar 11, 2024

This issue was closed because it has been stalled for 7 days with no activity.

@kubbot kubbot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in openim-powerful Mar 11, 2024
@cubxxw cubxxw reopened this Apr 1, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in openim-powerful Apr 1, 2024
@kubbot
Copy link
Contributor

kubbot commented Jul 15, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-project-automation github-project-automation bot moved this from In progress to Done in openim-powerful Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
openim-powerful
Status: Done
Milestone
v3.4
Development

No branches or pull requests
3 participants
@skiffer-git @cubxxw @kubbot