policy-serving: change the namespace for decapod randering #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
전체적으로 namespace 지정하는 부분에 대해 문제가 있습니다.
namespace는
두가지가 있는데 첫번째 지정된 내역으로 rendering이 수행되고 배포는 강제로 변경되는 형태로 동작됨
helm 배포는 두가지가 동시에 이뤄짐에 비해 오해의 소지가 발생함
현 pr도 동일한 이슈에서 발생한 것으로 모든 helm chart에서 이러한 문제를 잠재적으로 갖고 있음
helmchart 내부에 여러가지 자원들 중 namespace를 랜더링시 yaml로 기록하는 내역들이 있는데 이것도 serviceaccount를 랜더링시 사용한 네임스페이스에 고정했는데 workflow에서 다른 네임스페이스를 지정함으로써 발생함
따라서 추후에는 네임스페이스 통합이 필요함!!!