Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature. add chart for tks-portal #109

Merged
merged 2 commits into from
Mar 21, 2022
Merged

feature. add chart for tks-portal #109

merged 2 commits into from
Mar 21, 2022

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Mar 18, 2022

servicemesh portal chart 를 추가합니다.

@gitguardian
Copy link

gitguardian bot commented Mar 18, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2918100 Generic High Entropy Secret 24add95 servicemesh-portal/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ktkfree ktkfree force-pushed the add_servicemesh_portal branch from c172f54 to 8e8b192 Compare March 18, 2022 01:33
@ktkfree ktkfree requested a review from seungkyua March 20, 2022 14:10
@ktkfree ktkfree force-pushed the add_servicemesh_portal branch 4 times, most recently from 78230c4 to 4aa2ce9 Compare March 20, 2022 17:07
@ktkfree ktkfree changed the title [WIP] feature. add chart for tks-portal feature. add chart for tks-portal Mar 21, 2022
image:
repository: docker.io/ktkfree/servicemesh-portal
pullPolicy: Always
tag: "latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart 의 app version 과 portal image 버전을 1.0.0 으로 맞추는 것은 어떨까요? 이미지도 버전별로 관리해야 나중에 업그레이드 등도 수월할 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

char version, appversion, docker image version 모두 1.0.0으로 변경하였습니다.

@ktkfree ktkfree force-pushed the add_servicemesh_portal branch from e770424 to 24add95 Compare March 21, 2022 08:21
@ktkfree ktkfree merged commit d4d1840 into main Mar 21, 2022
@ktkfree ktkfree deleted the add_servicemesh_portal branch March 21, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants