-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature. add chart for tks-portal #109
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
2918100 | Generic High Entropy Secret | 24add95 | servicemesh-portal/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
c172f54
to
8e8b192
Compare
78230c4
to
4aa2ce9
Compare
servicemesh-portal/values.yaml
Outdated
image: | ||
repository: docker.io/ktkfree/servicemesh-portal | ||
pullPolicy: Always | ||
tag: "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chart 의 app version 과 portal image 버전을 1.0.0 으로 맞추는 것은 어떨까요? 이미지도 버전별로 관리해야 나중에 업그레이드 등도 수월할 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
char version, appversion, docker image version 모두 1.0.0으로 변경하였습니다.
e770424
to
24add95
Compare
servicemesh portal chart 를 추가합니다.