cluster-api-aws: use unique key for the machinedeployment raw yaml #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
release-v2에 적용하는 것을 확인 했습니다. |
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
robertchoi80
approved these changes
Apr 11, 2022
ktkfree
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
machinedeployment (이하 md) 생성 중간 단계인 configmap내 데이터를 생성하는 과정에서 키를 0부터 (AZ-1)까지 단순 숫자를 사용하였기 때문에 2개 이상의 md를 정의하는 경우 키가 중복되어 마지막 md의 내용만 적용되는 문제를 발견해서 수정합니다.
정의한 md의 이름과 0~(AZ-1) 까지 숫자를 조합해서 키를 사용하도록 변경하였습니다. 또한, 키의 마지막 문자는 0~(AZ-1) 값을 가지고 각 AZ에 생성된 서브넷 정보가 저장된 subnet 리스트의 인덱스로 사용됩니다.