Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluentbit에서 다수의 elastic cluster를 지원하도록 수정함 #132

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

intelliguy
Copy link
Contributor

@intelliguy intelliguy commented Jul 26, 2022

기존 단일 es를 가정하고 만들었던 부분을 멀티를 지원하도록 수정
기존 output.es 값을 리스트 형태로 넣어주면 됨.
사용을 위한 재지정 값의 예시를 examples 디렉토리에 추가함 (싱글, 멀티)

@intelliguy intelliguy changed the title WIP--Fb multi es fluentbit에서 다수의 elastic cluster를 지원하도록 수정함 Jul 26, 2022
@bluejayA
Copy link
Contributor

[INFO] Chart.yaml: icon is recommended
Warning: templates/operator/rbac.yaml: rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
Warning: templates/operator/webhook.yaml: admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration

lint check에 윗 워닝은 괜찮은거에요?

@intelliguy
Copy link
Contributor Author

warcronjob-backup-jenkins

[INFO] Chart.yaml: icon is recommended Warning: templates/operator/rbac.yaml: rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding Warning: templates/operator/webhook.yaml: admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration

lint check에 윗 워닝은 괜찮은거에요?

이 pr에서 발생한 것은 아니고 cronjob-backup-jenkins에서 발생한 내역입니다.

@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jul 30, 2022
@seungkyua seungkyua removed the Stale There has been no activity on this label Aug 1, 2022
username: taco-fluentbit
password: tacoword
elasticPasswordSecret: eck-elasticsearch-es-elastic-user
template:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template 하위에 templates 항목이 있는데 굉장히 어색합니다. template을 index (혹은 index_template? 이 것도 동어반복되는 느낌이...) 로 변경하는 것 어떻게 생각하시나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template는 템플릿이라는 큰 카테고리이고
그에 포함된 내역으로 실제 템플릿들(templates)과
템플릿으로 부터 만들어지는 인덱스를 관리하는 내역(ilms)을 포함하고 있습니다.
뭔가 정확한 용어로 정리하는 것은 좋아보이지만 제시하신 단어는 맞지 않네요.
그리고 본 pr과는 무관한 내용이므로 추후 refactoring시 고려하도록 하겠습니다.

@intelliguy intelliguy merged commit d4a3e6b into main Aug 2, 2022
@intelliguy intelliguy deleted the fb_multi_es branch August 2, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants