etcd election timout 설정 추가 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
requested review from
Jaesang,
intelliguy,
robertchoi80,
estherk0 and
seungkyua
| @@ -0,0 +1,6 @@ | |||
| dependencies: | |||
There was a problem hiding this comment.
helm-toolkit 은 어떤 library 때문에 사용되는 건가요?
There was a problem hiding this comment.
Jaesang
suggested changes
Mar 25, 2021
There was a problem hiding this comment.
helm install시 chart폴더가 없다는 에러가 나는데, 폴더에서 helm dep update를 해서 charts폴더에 helm-toolkit 차트가 있어야 Install이 됩니다.
$ helm install cluster-jaesang ./cluster-api-openstack -f values-override.yaml
Error: found in Chart.yaml, but missing in charts/ directory: helm-toolkit
If a disk or network has performance problems, increasing the timeout value can prevent unnecessary and frequent changes to the etcd leader.
zugwan
force-pushed
the
capo_etcd_timeout
branch
from
d50633f to
5c2ddf6
Compare
수정 내용 반영 후 코멘트를 남기었다고 생각했는데 최종 제출을 안한 듯 하네요. chats/ 디렉토리를 포함하여 반영하였습니다. |
estherk0
approved these changes
Mar 30, 2021
Jaesang
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
느린 디스크 등의 문제로 etcd 리더 변경이 자주 발생하는 환경에서 timeout 값 (기본: 1000ms -> 예: 10000) 증가시키면 문제 상황을 완화할 수 있습니다. 이를 설정하는 변수를 추가하였습니다.