Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create dashboards when it's enabled #34

Merged
merged 2 commits into from
May 6, 2021
Merged

create dashboards when it's enabled #34

merged 2 commits into from
May 6, 2021

Conversation

estherk0
Copy link
Contributor

@estherk0 estherk0 commented May 4, 2021

  • grafana dashboard를 모두 만들지 않고 종류별로 구분해서 enabled / disabled 시킬 수 있도록 한다.
  • ceph, kubernetes, node, openstack, taco custom 으로 분류

intelliguy
intelliguy approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@intelliguy intelliguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intelliguy intelliguy merged commit 9bd24ad into main May 6, 2021
@estherk0 estherk0 deleted the enabled-dashboard branch June 28, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugwan zugwan zugwan approved these changes

@intelliguy intelliguy intelliguy approved these changes

@Jaesang Jaesang Awaiting requested review from Jaesang

@robertchoi80 robertchoi80 Awaiting requested review from robertchoi80

@seungkyua seungkyua Awaiting requested review from seungkyua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estherk0 @zugwan @intelliguy