TACODEV-909: integrate postjobs, update version and so on #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
intelliguy
commented
Sep 27, 2021
intelliguy
commented
- integrate postjobs - initialize k8s for taco and register to argocd
- change error on duplicated registration to warning
- change rbac to allow 'kubectl apply'
- update version for cluster-api-aws
intelliguy
requested review from
Jaesang,
zugwan,
ktkfree,
robertchoi80,
seungkyua and
kyuho24
Jaesang
suggested changes
Sep 28, 2021
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
- integrate postjobs - initialize k8s for taco and register to argocd - change error on duplicated registration to warning - change rbac to allow 'kubectl apply' - update version for cluster-api-aws - add README.md
intelliguy
force-pushed
the
TACODEV-909_bugfix
branch
from
938a63b to
cad41cb
Compare
Jaesang
reviewed
Oct 8, 2021
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
Jaesang
approved these changes
Oct 14, 2021
ktkfree
approved these changes
Oct 15, 2021
| @@ -32,7 +32,7 @@ spec: | |||
| subPath: generate_machine_pool.py | |||
| mountPath: /generate_machine_pool.py | |||
|
|
|||
| {{- if .Values.job.taconode.enabled }} | |||
| {{- if or .Values.job.taconode.enabled .Values.job.argo.enabled }} | |||
There was a problem hiding this comment.
아래의 argo register 를 합치신것 같은데, 굳이 .Values.job.argo.enabled 가 or 조건으로 들어갈 필요가 있을까요?
There was a problem hiding this comment.
두개의 기능을 하나의 컨테이너에서 실행하도록 하면서 둘중의 하나라도 세팅되어 있으면 해당 컨테이너가 수행하도록 했습니다.
즉, 이전과 같이
- taconode를 초기화하는 기능과
- argo register를 하는 기능을
각각 사용할 수 있습니다.
이를 위한 장치입니다.
jamesdio
pushed a commit
to WnY-Tech/helm-charts
that referenced
this pull request
Nov 8, 2021
TACODEV-909: integrate postjobs, update version and so on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.