Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-api-aws) pre-deletion job 추가 #90

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

intelliguy
Copy link
Contributor

cluster-api-aws) Add a pre-deletion job to delete resources generated by a program
chart를 통해 최초설치하는 자원에대해 삭제하고 완료를 확인하는 job 추가

@intelliguy
Copy link
Contributor Author

#90

@robertchoi80
Copy link
Contributor

#89 (comment) 에도 적었는데, 지금 argocd 로 배포할 때 pre-delete hook이 동작을 하나요?

@intelliguy
Copy link
Contributor Author

https://argo-cd.readthedocs.io/en/stable/user-guide/helm/ 에 나온것처럼 argo에서는 동작하자 않습니다.
따라서 어제 논의한 방법으로 cluster를 삭제하여 하부의 자원을 cluster api가 지우도록 하는 것이 필요합니다.
본 티켓은 취지에 써 놓은 것처럼 helm chart의 완결성을 위해 생성한 것입니다.

@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jan 23, 2022
@intelliguy intelliguy removed the Stale There has been no activity on this label Jan 25, 2022
@intelliguy intelliguy merged commit 44ca78e into main Jan 25, 2022
@intelliguy intelliguy deleted the cluster-api-aws_pre-delete branch January 25, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants