feat: axelar oracle #137
Open
feat: axelar oracle #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reednaa
approved these changes
Oct 13, 2025
Member
reednaa
left a comment
reednaa
left a comment
There was a problem hiding this comment.
Looks fine to me.
Before we merge, we should consider a way to display which contracts (including oracles) have been audited and which have not.
Comment on lines
70
to
73
| if (source == address(0)) revert InvalidAddress(); | ||
| if (payloads.length == 0) revert EmptyPayloadsNotAllowed(); | ||
|
|
||
| if (!IAttester(source).hasAttested(payloads)) revert NotAllPayloadsValid(); |
Member
There was a problem hiding this comment.
(Opinion) Should be implemented in the outer submit function. The inner function is (mainly) concerned with messaging layer logic.
Comment on lines
+83
to
+85
| function gateway() public view returns (IAxelarGateway) { | ||
| return IAxelarGateway(gatewayAddress); | ||
| } |
Member
There was a problem hiding this comment.
Some strange code inherited from Axalar 😅
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
reednaa
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an Axelar-based oracle for cross-chain message attestation.
Oracle Implementation:
Public Interface:
Design Decisions:
Related Issues
There is no related issue.
Third-Party Integration Checklist
foundry.tomlsrc/oracles/[oracle-type]/external/[protocol-name]/Additional Notes