-
Notifications
You must be signed in to change notification settings - Fork 31
[hat] Proposal for bfloat16 #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jjfumero
wants to merge
19
commits into
openjdk:code-reflection
Choose a base branch
from
jjfumero:hat/type/bfloat16
base: code-reflection
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back jfumero! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the type
bfloat16for HAT.Testing for OpenCL:
HAT=SHOW_CODE java -cp hat/job.jar hat.java test ffi-opencl hat.test.TestBFloat16TypeTesting for CUDA:
HAT=SHOW_CODE java -cp hat/job.jar hat.java test ffi-cuda hat.test.TestBFloat16TypeSome tests are expecting to fail due to precision error. We will need to improve the type conversion with round-to-nearest-even for example.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/716/head:pull/716$ git checkout pull/716Update a local copy of the PR:
$ git checkout pull/716$ git pull https://git.openjdk.org/babylon.git pull/716/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 716View PR using the GUI difftool:
$ git pr show -t 716Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/716.diff