-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346768: [CRaC] Ignore errors parsing classpath #168
base: crac
Are you sure you want to change the base?
Conversation
👋 Welcome back TimPushkin! A progress list of the required criteria for merging this PR into |
@TimPushkin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/contributor add tpushkin |
@TimPushkin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/integrate |
@TimPushkin |
CRaC's classpath parsing now ignores exceptions being thrown when parsing the paths.
ClasspathParseTest
is extended to test the failure does not occur at least on Windows (no test case was found to triggernew File(...).toPath()
exceptions on other platforms).Progress
Issue
Reviewers
Contributors
<tpushkin@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/168/head:pull/168
$ git checkout pull/168
Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/crac.git pull/168/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 168
View PR using the GUI difftool:
$ git pr show -t 168
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/168.diff
Using Webrev
Link to Webrev Comment