Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346768: [CRaC] Ignore errors parsing classpath #168

Open
wants to merge 1 commit into
base: crac
Choose a base branch
from

Conversation

TimPushkin
Copy link
Contributor

@TimPushkin TimPushkin commented Dec 23, 2024

CRaC's classpath parsing now ignores exceptions being thrown when parsing the paths.

ClasspathParseTest is extended to test the failure does not occur at least on Windows (no test case was found to trigger new File(...).toPath() exceptions on other platforms).


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8346768: [CRaC] Ignore errors parsing classpath (Bug - P4)

Reviewers

Contributors

  • Timofei Pushkin <tpushkin@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/168/head:pull/168
$ git checkout pull/168

Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/crac.git pull/168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 168

View PR using the GUI difftool:
$ git pr show -t 168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/168.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back TimPushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346768: [CRaC] Ignore errors parsing classpath

Co-authored-by: Timofei Pushkin <tpushkin@openjdk.org>
Reviewed-by: rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the crac branch:

  • a2fb688: 8346766: [CRaC] tools/launcher/HelpFlagsTest.java and tools/launcher/VersionCheck.java tests fail on Windows
  • 2c9ab05: 8346765: [CRaC] Could not find criuengine on Windows and Mac

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

⚠️ @TimPushkin the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8346768
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2024
@TimPushkin
Copy link
Contributor Author

/contributor add tpushkin

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@TimPushkin
Contributor Timofei Pushkin <tpushkin@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

Copy link
Collaborator

@rvansa rvansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TimPushkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@TimPushkin
Your change (at version 5f572b7) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

2 participants