Skip to content

Commit

Permalink
8311964: Some jtreg tests failing on x86 with error 'unrecognized VM …
Browse files Browse the repository at this point in the history 
…options' (C2 flags)

Reviewed-by: dhanalla, thartmann
  • Loading branch information
@TobiHartmann
singhnitin authored and TobiHartmann committed Sep 6, 2023
1 parent 62a953f commit 024133b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
* @summary ArrayFill: if store is on backedge, last iteration is not to be executed.
* @library /test/lib
* @compile TestBackedgeLoadArrayFill.jasm
* @requires vm.compiler2.enabled
* @run main/othervm
* -XX:CompileCommand=compileonly,TestBackedgeLoadArrayFill*::test*
* -XX:-TieredCompilation -Xcomp -XX:+OptimizeFill
Expand Down
1 change: 1 addition & 0 deletions test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* @bug 8296412
* @compile TestInfiniteLoopWithUnmergedBackedges.jasm
* @summary Infinite loops may not have the backedges merged, before we call IdealLoopTree::check_safepts
* @requires vm.compiler2.enabled
* @run main/othervm -Xcomp -XX:-TieredCompilation -XX:-LoopUnswitching
* -XX:CompileCommand=compileonly,TestInfiniteLoopWithUnmergedBackedges::test*
* TestInfiniteLoopWithUnmergedBackedgesMain
Expand Down
1 change: 1 addition & 0 deletions test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* @test
* @bug 8299959
* @summary In CmpU::Value, the sub computation may be narrower than the overflow computation.
* @requires vm.compiler2.enabled
*
* @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+StressCCP -Xcomp -XX:-TieredCompilation
* -XX:CompileCommand=compileonly,compiler.rangechecks.TestRangeCheckCmpUOverflowVsSub::test
Expand Down

9 comments on commit 024133b

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@dcubed-ojdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tag jdk-22+14

@openjdk
Copy link

@openjdk openjdk bot commented on 024133b Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcubed-ojdk Only integrators for this repository are allowed to use the /tag command.

@dcubed-ojdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tag jdk-22+14

@openjdk
Copy link

@openjdk openjdk bot commented on 024133b Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcubed-ojdk The tag jdk-22+14 was successfully created.

@sendaoYan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 024133b Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan the backport was successfully created on the branch backport-sendaoYan-024133b0 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 024133b0 from the openjdk/jdk repository.

The commit being backported was authored by singhnitin on 6 Sep 2023 and was reviewed by Dhamoder Nalla and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-sendaoYan-024133b0:backport-sendaoYan-024133b0
$ git checkout backport-sendaoYan-024133b0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-sendaoYan-024133b0

@sendaoYan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 024133b Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan the backport was successfully created on the branch backport-sendaoYan-024133b0 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 024133b0 from the openjdk/jdk repository.

The commit being backported was authored by singhnitin on 6 Sep 2023 and was reviewed by Dhamoder Nalla and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-sendaoYan-024133b0:backport-sendaoYan-024133b0
$ git checkout backport-sendaoYan-024133b0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-sendaoYan-024133b0

⚠️ @sendaoYan You are not yet a collaborator in my fork openjdk-bots/jdk17u-dev. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.