Skip to content

Commit

Permalink
8340974: Ambiguous name of jtreg property vm.libgraal.enabled
Browse files Browse the repository at this point in the history
Reviewed-by: dnsimon, phh
  • Loading branch information
toddjonker authored and Paul Hohensee committed Sep 26, 2024
1 parent 5d062e2 commit 2349bb7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion test/hotspot/jtreg/TEST.ROOT
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ requires.properties= \
vm.jvmti \
vm.graal.enabled \
jdk.hasLibgraal \
vm.libgraal.enabled \
vm.libgraal.jit \
vm.compiler1.enabled \
vm.compiler2.enabled \
vm.musl \
Expand Down
7 changes: 3 additions & 4 deletions test/jtreg-ext/requires/VMProps.java
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ public Map<String, String> call() {
map.put("vm.graal.enabled", this::isGraalEnabled);
// jdk.hasLibgraal is true if the libgraal shared library file is present
map.put("jdk.hasLibgraal", this::hasLibgraal);
// vm.libgraal.enabled is true if libgraal is used as JIT
map.put("vm.libgraal.enabled", this::isLibgraalEnabled);
map.put("vm.libgraal.jit", this::isLibgraalJIT);
map.put("vm.compiler1.enabled", this::isCompiler1Enabled);
map.put("vm.compiler2.enabled", this::isCompiler2Enabled);
map.put("docker.support", this::dockerSupport);
Expand Down Expand Up @@ -560,8 +559,8 @@ protected String hasLibgraal() {
*
* @return true if libgraal is used as JIT compiler.
*/
protected String isLibgraalEnabled() {
return "" + Compiler.isLibgraalEnabled();
protected String isLibgraalJIT() {
return "" + Compiler.isLibgraalJIT();
}

/**
Expand Down
4 changes: 2 additions & 2 deletions test/lib/jdk/test/whitebox/code/Compiler.java
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ public static boolean isGraalEnabled() {
/**
* Check if libgraal is used as JIT compiler.
*
* libraal is enabled if isGraalEnabled is true and:
* libraal JIT is enabled if isGraalEnabled is true and:
* - UseJVMCINativeLibrary flag is true
*
* @return true if libgraal is used as JIT compiler.
*/
public static boolean isLibgraalEnabled() {
public static boolean isLibgraalJIT() {
if (!isGraalEnabled()) {
return false;
}
Expand Down

1 comment on commit 2349bb7

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.