Skip to content

Commit

Permalink
8321105: Enable UseCryptoPmullForCRC32 for Neoverse V2
Browse files Browse the repository at this point in the history 
Reviewed-by: shade, ngasson
  • Loading branch information
Evgeny Astigeevich committed Dec 5, 2023
1 parent 4fbf22b commit 5b02188
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,11 @@ void VM_Version::initialize() {
}
}

// Neoverse N1, N2, V1, V2
// Neoverse
// N1: 0xd0c
// N2: 0xd49
// V1: 0xd40
// V2: 0xd4f
if (_cpu == CPU_ARM && (model_is(0xd0c) || model_is(0xd49) ||
model_is(0xd40) || model_is(0xd4f))) {
if (FLAG_IS_DEFAULT(UseSIMDForMemoryOps)) {
Expand Down Expand Up @@ -235,8 +239,10 @@ void VM_Version::initialize() {
FLAG_SET_DEFAULT(UseCRC32, false);
}

// Neoverse V1
if (_cpu == CPU_ARM && model_is(0xd40)) {
// Neoverse
// V1: 0xd40
// V2: 0xd4f
if (_cpu == CPU_ARM && (model_is(0xd40) || model_is(0xd4f))) {
if (FLAG_IS_DEFAULT(UseCryptoPmullForCRC32)) {
FLAG_SET_DEFAULT(UseCryptoPmullForCRC32, true);
}
Expand Down

3 comments on commit 5b02188

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@pengxiaolong
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 5b02188 Jun 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengxiaolong Could not automatically backport 5b02188f to openjdk/jdk21u-dev due to conflicts in the following files:

  • src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-pengxiaolong-5b02188f-master

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 5b02188f723e0de3faf2d8150b676a4383e1f618

# Backport the commit
$ git cherry-pick --no-commit 5b02188f723e0de3faf2d8150b676a4383e1f618
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 5b02188f723e0de3faf2d8150b676a4383e1f618'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u-dev with the title Backport 5b02188f723e0de3faf2d8150b676a4383e1f618.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5b02188f from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 5 Dec 2023 and was reviewed by Aleksey Shipilev and Nick Gasson.

Thanks!

Please sign in to comment.