Skip to content

Commit

Permalink
8316428: G1: Nmethod count statistics only count last code root set i…
Browse files Browse the repository at this point in the history 
…terated

Reviewed-by: iwalulya, ayang
  • Loading branch information
Thomas Schatzl committed Sep 19, 2023
1 parent 283c360 commit fab372d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/g1RemSet.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ class G1ScanCollectionSetRegionClosure : public HeapRegionClosure {
// Scan the code root list attached to the current region
r->code_roots_do(&cl);

_code_roots_scanned = cl.count();
_code_roots_scanned += cl.count();

event.commit(GCId::current(), _worker_id, G1GCPhaseTimes::phase_name(_code_roots_phase));
}
Expand Down

5 comments on commit fab372d

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@jianglizhou
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u

@openjdk
Copy link

@openjdk openjdk bot commented on fab372d Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianglizhou the backport was successfully created on the branch backport-jianglizhou-fab372d3-master in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit fab372d3 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 19 Sep 2023 and was reviewed by Ivan Walulya and Albert Mingkun Yang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git backport-jianglizhou-fab372d3-master:backport-jianglizhou-fab372d3-master
$ git checkout backport-jianglizhou-fab372d3-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git backport-jianglizhou-fab372d3-master

@jianglizhou
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on fab372d Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianglizhou the backport was successfully created on the branch backport-jianglizhou-fab372d3-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit fab372d3 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 19 Sep 2023 and was reviewed by Ivan Walulya and Albert Mingkun Yang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-jianglizhou-fab372d3-master:backport-jianglizhou-fab372d3-master
$ git checkout backport-jianglizhou-fab372d3-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-jianglizhou-fab372d3-master

⚠️ @jianglizhou You are not yet a collaborator in my fork openjdk-bots/jdk21u-dev. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.