Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256014: Eliminate the warning about serialization in non-public API of Swing #1110

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 8, 2020

As part of the serialization cleanup, I would like to remove the serialization warning below from the non-public API(mostly motif and windows L&Fs). Later I will remove it from the public API and move this warning to the "javax.swing" package spec.

 * <strong>Warning:</strong>
 * Serialized objects of this class will not be compatible with
 * future Swing releases. The current serialization support is appropriate
 * for short term storage or RMI between applications running the same
 * version of Swing. A future release of Swing will provide support for
 * long term persistence.

Note that this warning is useless because the UI delegates(parts of L&F) should never be serialized. Such classes were marked as "Serializable" by accident. If the component like JButton is serialized then parts related to the L&F are removed from the stream. This is because default L&F could be different before/after serialization.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8256014: Eliminate the warning about serialization in non-public API of Swing

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1110/head:pull/1110
$ git checkout pull/1110

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2020

@mrserb The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Nov 8, 2020
@mrserb mrserb marked this pull request as ready for review November 9, 2020 00:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 9, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256014: Eliminate the warning about serialization in non-public API of Swing

Reviewed-by: prr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 3ce09c0: 8255920: J2DBench should support CS_PYCC color profile
  • 2c8f4e2: 8255799: AArch64: CPU_A53MAC feature may be set incorrectly
  • 2cad836: 8255575: java.awt.color.ICC_ColorSpace is not thread-safe
  • a53b12d: 8255722: Create a new test for rotated blit
  • f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
  • ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
  • 6a183fb: 8255562: delete UseRDPCForConstantTableBase

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2020
@mrserb
Copy link
Member Author

mrserb commented Nov 9, 2020

/integrate

@openjdk openjdk bot closed this Nov 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2020
@openjdk
Copy link

openjdk bot commented Nov 9, 2020

@mrserb Since your change was applied there have been 8 commits pushed to the master branch:

  • 2d6c28d: 6847157: java.lang.NullPointerException: HDC for component at sun.java2d.loops.Blit.Blit
  • 3ce09c0: 8255920: J2DBench should support CS_PYCC color profile
  • 2c8f4e2: 8255799: AArch64: CPU_A53MAC feature may be set incorrectly
  • 2cad836: 8255575: java.awt.color.ICC_ColorSpace is not thread-safe
  • a53b12d: 8255722: Create a new test for rotated blit
  • f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
  • ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
  • 6a183fb: 8255562: delete UseRDPCForConstantTableBase

Your commit was automatically rebased without conflicts.

Pushed as commit c7551c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this pull request Nov 9, 2020
@mrserb mrserb deleted the JDK-8256014 branch November 9, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants