8256393: Github Actions build on Linux should define OS and GCC versions #1225

rwestberg · 2020-11-16T12:51:25Z

We should be more explicit about OS and compiler versions used in the GitHub Actions builds, to avoid problems caused by unexpected changes to the defaults. This patch changes the OS and GCC versions used from ubuntu-latest (currently 18.04, but will change to 20.04 sometime soon) / default (currently 9.3.0) to 20.04 / 10.2.0.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux aarch64	Linux arm	Linux ppc64le	Linux s390x	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)					✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

JDK-8256393: Github Actions build on Linux should define OS and GCC versions

Reviewers

Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 87ab072
Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 87ab072
Magnus Ihse Bursie (@magicus - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1225/head:pull/1225
$ git checkout pull/1225

bridgekeeper · 2020-11-16T12:52:14Z

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-11-16T12:54:59Z

@rwestberg The following label will be automatically applied to this pull request:

build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2020-11-16T12:58:34Z

Webrevs

shipilev

Hold on a sec. ubuntu-latest is ubuntu-18.04, as per GH manual. So this effectively upgrades the whole thing to Ubuntu 20.04, and upgrades GCC then? I think we better stick to current defaults, i.e. ubuntu-18.04 and its GCC.

In JDK-8256277, we did not upgrade MacOS target either...

shipilev · 2020-11-16T13:11:09Z

.github/workflows/submit.yml

@@ -88,7 +88,7 @@ jobs:
        if: steps.check_submit.outputs.should_run != 'false' && steps.jtreg.outputs.cache-hit != 'true'

      - name: Build jtreg
-        run: sh make/build-all.sh ${JAVA_HOME}
+        run: sh make/build-all.sh ${JAVA_HOME_8_X64}


What is this change?

On ubuntu-20.04 the default Java installation is now set to 11, but jtreg still requires Java 8 for building.

I see! Okay then.

rwestberg · 2020-11-16T13:34:01Z

Right, currently ubuntu-latest means 18.04, but that is only true for another two weeks (see actions/runner-images#1816 - originally it was also planned for next week). So I think we should go straight for the upcoming latest.

shipilev · 2020-11-16T13:36:20Z

.github/workflows/submit.yml

@@ -88,7 +88,7 @@ jobs:
        if: steps.check_submit.outputs.should_run != 'false' && steps.jtreg.outputs.cache-hit != 'true'

      - name: Build jtreg
-        run: sh make/build-all.sh ${JAVA_HOME}
+        run: sh make/build-all.sh ${JAVA_HOME_8_X64}


I see! Okay then.

openjdk · 2020-11-16T13:37:31Z

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256393: Github Actions build on Linux should define OS and GCC versions

Reviewed-by: shade, erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

b8244b6: 8236926: Concurrently uncommit memory in G1
defdd12: 8142984: Zero: fast accessors should handle both getters and setters
1718aba: 8227400: Adjust jib profiles to make 3rd party tools for creating installers available on Mach5 test machines
9bb8223: 8253299: Manifest bytes are read twice when verifying a signed JAR
580f22c: 8256581: Refactor vector conversion tests
675d1d5: 8256516: Simplify clearing References
ba721f5: 8212879: Make JVMTI TagMap table concurrent
3a4b90f: 8202343: Disable TLS 1.0 and 1.1
342ccf6: 8256253: Defer Biased Locking obsoletion to JDK 18
d183fc7: 8221554: aarch64 cross-modifying code
... and 70 more: https://git.openjdk.java.net/jdk/compare/8eeb36f14a9121b6cb1ed3228f78021d5da9e81b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

shipilev · 2020-11-16T13:37:48Z

Right, currently ubuntu-latest means 18.04, but that is only true for another two weeks (see actions/virtual-environments#1816 - originally it was also planned for next week). So I think we should go straight for the upcoming latest.

All right, changing this today makes sense to me.

magicus · 2020-11-16T14:27:39Z

.github/workflows/submit.yml

-        run: sudo apt-get install libxrandr-dev libxtst-dev libcups2-dev libasound2-dev
+        run: |
+          sudo apt-get install libxrandr-dev libxtst-dev libcups2-dev libasound2-dev
+          sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10


Maybe we should use apt-get functionality to install a specific version of packages? I'm not sure how relevant it is for the X and alsa libraries since they change very seldom, but perhaps for gcc, to get a specific point release of the compiler.

Something along the lines of sudo apt-get install gcc-10=10.2.0-5ubuntu1~20, which I believe should match quite well the version used internally in the Oracle CI builds.

That sounds reasonable, I don't know how often these change in Ubuntu LTS, but can't hurt to be explicit here as well.

mlbridge · 2020-11-16T15:34:12Z

Mailing list message from Tiago Daitx on build-dev:

Hi,

89:
90: - name: Build jtreg
91: run: sh make/build-all.sh ${JAVA_HOME_8_X64}

What is this change?

On ubuntu-20.04 the default Java installation is now set to 11, but jtreg still requires Java 8 for building.

Why does jtreg need OpenJDK-8 for building? On Debian/Ubuntu we have
been using the 'release' parameter to build jtreg using OpenJDK 11
while maintaining OpenJDK 8 compatibility. See
https://sources.debian.org/src/jtreg/5.1-b01-2/debian/patches/use-release-instead-of-source-target.patch/
for how we do it.

Please note that while we replace "source/target" for "release", one
can specify both "source/target" and "release" for a javac task: ant
is smart enough to pick one and ignore the other, depending on it
being run on JDK9+ or not. See 'release' description at
https://ant.apache.org/manual/Tasks/javac.html

Cheers!

--
Tiago St?rmer Daitx
Software Engineer
tiago.daitx at canonical.com

PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE

rwestberg · 2020-11-17T09:24:00Z

Why does jtreg need OpenJDK-8 for building?

Fair enough, the 1.8 requirement comes from using build-all.sh which checks this explicitly. But I'd rather leave changing how we build jtreg for a separate change..

magicus

LGTMN.

rwestberg · 2020-11-20T08:03:41Z

/integrate

openjdk · 2020-11-20T08:04:34Z

@rwestberg Since your change was applied there have been 90 commits pushed to the master branch:

5fedb69: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
02adaa5: 8255885: Metaspace: freelist commit counter is not updated when purging
fa240f2: 8256594: Unexpected warning: SIGSEGV handler flags expected:SA_RESTART|SA_SIGINFO found:SA_RESTART|SA_SIGINFO
4c09525: 8256108: Create implementation for NSAccessibilityElement protocol peer
6813889: 8251317: Support for CLDR version 38
c816464: 4916923: In MetalRootPaneUI, MetalRootLayout does not correctly calculate minimumsize
fae68ff: 8256640: assert(!m->is_old() || ik()->is_being_redefined()) failed: old methods should not be in vtable
c140773: 8256692: Zero: remove obsolete block from ZeroInterpreter::native_entry
080c707: 8253459: Formatter treats index, width and precision > Integer.MAX_VALUE incorrectly
b9db002: 8256682: JDK-8202343 is incomplete
... and 80 more: https://git.openjdk.java.net/jdk/compare/8eeb36f14a9121b6cb1ed3228f78021d5da9e81b...master

Your commit was automatically rebased without conflicts.

Pushed as commit c45ab1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Reviewed-by: shade, erikj, ihse

Select Ubuntu 20.04 and GCC 10

87ab072

openjdk bot changed the title ~~8256393~~ 8256393: Github Actions build on Linux should define OS and GCC versions Nov 16, 2020

openjdk bot added the rfr Pull request is ready for review label Nov 16, 2020

openjdk bot added the build build-dev@openjdk.org label Nov 16, 2020

shipilev suggested changes Nov 16, 2020

View reviewed changes

shipilev approved these changes Nov 16, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2020

erikj79 approved these changes Nov 16, 2020

View reviewed changes

magicus reviewed Nov 16, 2020

View reviewed changes

Robin Westberg added 2 commits November 19, 2020 17:09

Select gcc/g++ package versions explicitly

3dcb26d

Use proper package version

12b1ffe

magicus approved these changes Nov 19, 2020

View reviewed changes

openjdk bot closed this Nov 20, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2020

openjdk-notifier bot referenced this pull request Nov 20, 2020

8256393: Github Actions build on Linux should define OS and GCC versions

c45ab1a

Reviewed-by: shade, erikj, ihse

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8256393: Github Actions build on Linux should define OS and GCC versions #1225

8256393: Github Actions build on Linux should define OS and GCC versions #1225

rwestberg commented Nov 16, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 16, 2020

openjdk bot commented Nov 16, 2020

mlbridge bot commented Nov 16, 2020 •

edited

Loading

shipilev left a comment •

edited

Loading

shipilev Nov 16, 2020

rwestberg Nov 16, 2020

shipilev Nov 16, 2020

rwestberg commented Nov 16, 2020

shipilev Nov 16, 2020

openjdk bot commented Nov 16, 2020 •

edited

Loading

shipilev commented Nov 16, 2020

magicus Nov 16, 2020

magicus Nov 16, 2020 •

edited

Loading

rwestberg Nov 19, 2020

mlbridge bot commented Nov 16, 2020

rwestberg commented Nov 17, 2020

magicus left a comment

rwestberg commented Nov 20, 2020

openjdk bot commented Nov 20, 2020

8256393: Github Actions build on Linux should define OS and GCC versions #1225

8256393: Github Actions build on Linux should define OS and GCC versions #1225

Conversation

rwestberg commented Nov 16, 2020 • edited by openjdk bot Loading

Progress

Testing

Issue

Reviewers

Download

bridgekeeper bot commented Nov 16, 2020

openjdk bot commented Nov 16, 2020

mlbridge bot commented Nov 16, 2020 • edited Loading

Webrevs

shipilev left a comment • edited Loading

Choose a reason for hiding this comment

shipilev Nov 16, 2020

Choose a reason for hiding this comment

rwestberg Nov 16, 2020

Choose a reason for hiding this comment

shipilev Nov 16, 2020

Choose a reason for hiding this comment

rwestberg commented Nov 16, 2020

shipilev Nov 16, 2020

Choose a reason for hiding this comment

openjdk bot commented Nov 16, 2020 • edited Loading

shipilev commented Nov 16, 2020

magicus Nov 16, 2020

Choose a reason for hiding this comment

magicus Nov 16, 2020 • edited Loading

Choose a reason for hiding this comment

rwestberg Nov 19, 2020

Choose a reason for hiding this comment

mlbridge bot commented Nov 16, 2020

rwestberg commented Nov 17, 2020

magicus left a comment

Choose a reason for hiding this comment

rwestberg commented Nov 20, 2020

openjdk bot commented Nov 20, 2020

rwestberg commented Nov 16, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 16, 2020 •

edited

Loading

shipilev left a comment •

edited

Loading

openjdk bot commented Nov 16, 2020 •

edited

Loading

magicus Nov 16, 2020 •

edited

Loading