8256172: Clean up CDS handling of i2i_entry

[iklam]

This PR is a prerequisite for JDK-8250989 - Consolidate buffer allocation code for CDS static/dynamic archive dumping.

• Move the allocation of the i2i buffer after all classes are loaded. This makes it possible to estimate the size of the CDS archive before we allocate the output space (this is what dynamic archive does now).
• No need to generate the i2i trampoline code during -Xshare:dump
• Clean up the CDS code in abstractInterpreter.cpp and add more comments.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8256172: Clean up CDS handling of i2i_entry

Reviewers

• Yumin Qi (@yminqi - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1280/head:pull/1280
$ git checkout pull/1280

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (a7b0850)
• 00: Full (5262f24)

[openjdk]

@iklam this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8256172-cleanup-cds-i2i-entry
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[yminqi]

16 looks arbitrary number though we know it is minimal object alignment --- maybe we we can use object_alignment instead? up to you.

[iklam]

16 is just an arbitrary small number. MetaspaceShared::misc_code_space_alloc(16) will round up the size to the appropriate alignment. So I think I'll keep the existing code.

[yminqi]

Look good to me.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256172: Clean up CDS handling of i2i_entry

Reviewed-by: minqi, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• cfa92a5: 8256178: Add RAII object for file lock
• 2b15571: 8256383: PlatformMutex::try_lock has different semantics on Windows and Posix
• 99eac53: 8225631: Consider replacing muxAcquire/Release with PlatformMonitor
• 646c200: 8256152: tests fail because of ambiguous method resolution
• 5912df2: 8256427: Test com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work on AIX
• 3110d58: 8256538: Fix annoying awk warning in configure for java versions
• 03e84ef: 8256189: Exact VarHandle tests should test withInvokeBehavior() works as expected
• 300cbaa: 8256418: Jittester make build is broken.
• c9c1573: 8256567: ProblemList java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java for Xcomp testing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

Cleanup looks good.

[iklam]

Thanks @calvinccheung and @yminqi for the review.
/integrate

[openjdk]

@iklam Since your change was applied there have been 9 commits pushed to the master branch:

• cfa92a5: 8256178: Add RAII object for file lock
• 2b15571: 8256383: PlatformMutex::try_lock has different semantics on Windows and Posix
• 99eac53: 8225631: Consider replacing muxAcquire/Release with PlatformMonitor
• 646c200: 8256152: tests fail because of ambiguous method resolution
• 5912df2: 8256427: Test com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work on AIX
• 3110d58: 8256538: Fix annoying awk warning in configure for java versions
• 03e84ef: 8256189: Exact VarHandle tests should test withInvokeBehavior() works as expected
• 300cbaa: 8256418: Jittester make build is broken.
• c9c1573: 8256567: ProblemList java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java for Xcomp testing

Your commit was automatically rebased without conflicts.

Pushed as commit 4178834.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.