Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Jun 24, 2023

This patch tries to optimize classfile reading and writing with multibyte reading and writing utilities in the JDK. If #14636 is integrated first, this patch can be updated to use the improved ByteArray.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14637/head:pull/14637
$ git checkout pull/14637

Update a local copy of the PR:
$ git checkout pull/14637
$ git pull https://git.openjdk.org/jdk.git pull/14637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14637

View PR using the GUI difftool:
$ git pr show -t 14637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14637.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2023

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2023

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 24, 2023
@liach
Copy link
Member Author

liach commented Jun 25, 2023

The results in jdk.classfile.Write benchmark shows no discernable difference. Might need other benchmarks to check out actual performance differences.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2023

@liach This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2023

@liach This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant