Skip to content

8326617: String Template FMT removes unnecessary int to long type cast #16017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wenshao wants to merge 2 commits into from
Closed

8326617: String Template FMT removes unnecessary int to long type cast #16017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c314d
fix format %d int call prepend(long, byte[], long), should be call pr…
wenshao Oct 2, 2023
86018b6
Merge remote-tracking branch 'upstream/master' into st_prepend_int
wenshao Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/java.base/share/classes/java/util/FormatterBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,16 @@ private MethodHandle formatSpecifier(FormatSpecifier fs, Class<?> ptype) {
}
case DECIMAL_INTEGER -> {
if ((itype == int.class || itype == long.class) && precision == -1) {
if (flags == 0 && isGenericDFS && width == -1) {
return mh;
}

if (itype == int.class) {
mh = explicitCastArguments(mh,
mh.type().changeReturnType(long.class));
}

if (flags == 0 && isGenericDFS && width == -1) {
return mh;
} else if (validFlags(flags, PLUS | LEADING_SPACE |
if (validFlags(flags, PLUS | LEADING_SPACE |
ZERO_PAD | GROUP |
PARENTHESES)) {
handled = true;
Expand Down