8340808: RISC-V: Client build fails after JDK-8339738

[Hamlin-Li]

Hi,
Can you help to review this simple patch?
Previously, the crc32 intrinsic (scalar version) was added for both c1/c2, then the vector version was added but depends on a global flag MaxVectorSize which is only valid in c2.
This pr is to put all vector crc32 related code under COMPILER2 macro protection.
I tested with/without --with-jvm-variants=client.
Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340808: RISC-V: Client build fails after JDK-8339738 (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21159/head:pull/21159
$ git checkout pull/21159

Update a local copy of the PR:
$ git checkout pull/21159
$ git pull https://git.openjdk.org/jdk.git pull/21159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21159

View PR using the GUI difftool:
$ git pr show -t 21159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21159.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340808: RISC-V: Client build fails after JDK-8339738

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

• 9bcc7b6: 8340708: Optimize StackMapGenerator::processMethod
• a37bb2e: 8340643: RISC-V: Small refactoring for sub/subw macro-assembler routines
• c0fcb25: 8340717: Remove unused function declarations from java.c/java.h of the launcher
• 0b8c9f6: 8338525: Leading and trailing code blocks by indentation
• b639661: 8340804: doc/building.md update Xcode instructions to note that full install is required
• e3d80f1: 8340670: Policy.UNSUPPORTED_EMPTY_COLLECTION.isReadOnly does not return true
• 8c08c43: 8340433: Open source closed choice tests optimization algorithm：tableSizeFor #3
• 90c2c0b: 8340143: Open source several Java2D rendering loop tests.
• 212e329: 8338694: x86_64 intrinsic for tanh using libm
• 2669e22: 8340793: Fix client builds after JDK-8337987
• ... and 76 more: https://git.openjdk.org/jdk/compare/8908812d0a64f25f0d033d44725a69348789b223...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (60bb7bf2)

[Hamlin-Li]

Thanks @RealFYang for your reviewing!

I'll push this with one reviewer, as it's a trivial change.

/integrate

[openjdk]

Going to push as commit 9806d21.
Since your change was applied there have been 90 commits pushed to the master branch:

• 97a3933: 8339771: RISC-V: Reduce icache flushes
• b1f8d2e: 8339935: Open source several AWT focus tests - series 5
• 2e0554a: 8340710: Optimize DirectClassBuilder::build
• 2d38af6: 8340587: Optimize StackMapGenerator$Frame::checkAssignableTo
• 9bcc7b6: 8340708: Optimize StackMapGenerator::processMethod
• a37bb2e: 8340643: RISC-V: Small refactoring for sub/subw macro-assembler routines
• c0fcb25: 8340717: Remove unused function declarations from java.c/java.h of the launcher
• 0b8c9f6: 8338525: Leading and trailing code blocks by indentation
• b639661: 8340804: doc/building.md update Xcode instructions to note that full install is required
• e3d80f1: 8340670: Policy.UNSUPPORTED_EMPTY_COLLECTION.isReadOnly does not return true
• ... and 80 more: https://git.openjdk.org/jdk/compare/8908812d0a64f25f0d033d44725a69348789b223...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 9806d21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.